Skip to content

LIMS-1814: Add min images filter to summary page#966

Merged
ndg63276 merged 1 commit intopre-release/2025-R4.1from
improvement/LIMS-1814/add-min-images-filter-to-summary
Sep 2, 2025
Merged

LIMS-1814: Add min images filter to summary page#966
ndg63276 merged 1 commit intopre-release/2025-R4.1from
improvement/LIMS-1814/add-min-images-filter-to-summary

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-1814

Summary:

The summary page (eg https://ispyb.diamond.ac.uk/dc/summary/visit/nt37104-180) only shows data collections with more than 150 images, to avoid showing Characterization experiments. But this excludes lots of data from eg VMXi, so we should remove it, and replace with an optional filter.

Changes:

  • Add a filter for minimum number of images, rather than a hard-coded 150 image minimum
  • Fix a bug where going to a late page number and then filtering would crash the page

To test:

  • Go to /dc/summary/visit/nt37104-180
  • Check the number of pages of results is 23, and the last result is "image_253141"
  • Add a filter of minimum images = 151, check the number of pages reduces to 19, and the last result is "image_255476"
  • Go to the last page of results, then add a filter that would reduce the number of pages to less than the page you are on (eg 99% completeness). Check you are taken to page 1 of the results.
  • Clear the filters and check the number of pages returns to 23.

@gfrn gfrn self-requested a review July 29, 2025 15:50
@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R4.1 September 2, 2025 10:06
@ndg63276 ndg63276 merged commit c5c0422 into pre-release/2025-R4.1 Sep 2, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1814/add-min-images-filter-to-summary branch September 2, 2025 10:08
ndg63276 added a commit that referenced this pull request Sep 16, 2025
* LIMS-1856: Fix offset for plates (#973)

* LIMS-1839: Fix fast_dp radiation damage plots (#964)

* LIMS-1814: Add min images filter to summary page (#966)

* LIMS-1804: Make barcode be required for new plates (#969)

* LIMS-1802: Improvements to Add Shipment page (#972)

* LIMS-1784: Add drawing for Cryo EM Puck (#970)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants