Skip to content

LIMS-1839: Fix fast_dp radiation damage plots#964

Merged
ndg63276 merged 1 commit intopre-release/2025-R4.1from
fix/LIMS-1839/fix-radiation-damage-plots
Sep 2, 2025
Merged

LIMS-1839: Fix fast_dp radiation damage plots#964
ndg63276 merged 1 commit intopre-release/2025-R4.1from
fix/LIMS-1839/fix-radiation-damage-plots

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-1839

Summary:

Fast dp radiation damage plots stopped working when some fast_dp files were moved to a different folder.

Changes:

  • Search specifically for the xdsstat.log file, not just any fast_dp file

To test:

  • Go to a recent data collection with successful fast_dp (eg /dc/visit/cm40607-3/id/19021858)
  • Click on Auto Processing, choose the fast_dp tab, then click Radiation Damage. Check a plot appears.
  • Repeat for an older data collection before the files were moved (eg /dc/visit/cm40607-1/id/17183638)

@gfrn
Copy link
Copy Markdown
Collaborator

gfrn commented Jul 25, 2025

Does this warrant a configuration option, or is it not likely to change in the future? (judging by the Slack thread, I don't think it'll change much, but just in case)

@ndg63276
Copy link
Copy Markdown
Collaborator Author

Does this warrant a configuration option, or is it not likely to change in the future? (judging by the Slack thread, I don't think it'll change much, but just in case)

What would you put the config option on, the filename? I don't think it will change.

@gfrn
Copy link
Copy Markdown
Collaborator

gfrn commented Jul 25, 2025

Does this warrant a configuration option, or is it not likely to change in the future? (judging by the Slack thread, I don't think it'll change much, but just in case)

What would you put the config option on, the filename? I don't think it will change.

Would be, but since it won't change often, I guess that's not needed

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R4.1 September 2, 2025 10:06
@ndg63276 ndg63276 merged commit 1b10814 into pre-release/2025-R4.1 Sep 2, 2025
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1839/fix-radiation-damage-plots branch September 2, 2025 10:08
ndg63276 added a commit that referenced this pull request Sep 16, 2025
* LIMS-1856: Fix offset for plates (#973)

* LIMS-1839: Fix fast_dp radiation damage plots (#964)

* LIMS-1814: Add min images filter to summary page (#966)

* LIMS-1804: Make barcode be required for new plates (#969)

* LIMS-1802: Improvements to Add Shipment page (#972)

* LIMS-1784: Add drawing for Cryo EM Puck (#970)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants