Skip to content

LIMS-1799: Checks for safety level should be case insensitive#955

Merged
ndg63276 merged 1 commit intopre-release/2025-R4.2from
fix/LIMS-1799/safety-level-should-be-case-insensitive
Sep 16, 2025
Merged

LIMS-1799: Checks for safety level should be case insensitive#955
ndg63276 merged 1 commit intopre-release/2025-R4.2from
fix/LIMS-1799/safety-level-should-be-case-insensitive

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

@ndg63276 ndg63276 commented Jul 8, 2025

JIRA ticket: LIMS-1799

Summary:

#827 introduced a check on the shipment safety level, for queueing containers, but the check was case sensitive. This makes it case-insensitive as the field is text, not an enum.
Also fix a couple of minor things that github complains about in PRs.

Changes:

  • Make the check for shipping safety level be case insensitive
  • Do not access Object.prototype method 'hasOwnProperty' from target object, use Object.prototype.hasOwnProperty.call instead
  • Use this.$ instead of $ in views

To test:

  • Set a shipment to safety level 'GREEN', eg
update Shipping set SAFETYLEVEL='GREEN' where shippingId=71932;
  • Go to /containers/cid/341023 and check the puck can be unqueued and queued freely
  • Set the same shipment to 'YELLOW' (or any capitalisation, refresh the page and check the puck cannot be queued any more.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R4.2 September 16, 2025 09:58
@ndg63276 ndg63276 merged commit 7f22241 into pre-release/2025-R4.2 Sep 16, 2025
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1799/safety-level-should-be-case-insensitive branch September 16, 2025 10:00
ndg63276 added a commit that referenced this pull request Sep 30, 2025
* LIMS-1844: Update archiving messages for 'il' proposals (#977)

* LIMS-1807: Leave 'Mark Dispensing' button active until cancelled (#967)

* LIMS-1799: Checks for safety level should be case insensitive (#955)

* LIMS-1786: Add Dewars column to Shipments page (#958)

* LIMS-1426: Allow setting of pipeline when ranking samples (#950)

* LIMS-1783: Add parent container dropdown for gridboxes (#965)

* LIMS-1903: Fix display of shipping labels (#984)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants