LIMS-1799: Checks for safety level should be case insensitive#955
Merged
ndg63276 merged 1 commit intopre-release/2025-R4.2from Sep 16, 2025
Merged
Conversation
gfrn
approved these changes
Jul 16, 2025
ndg63276
added a commit
that referenced
this pull request
Sep 30, 2025
* LIMS-1844: Update archiving messages for 'il' proposals (#977) * LIMS-1807: Leave 'Mark Dispensing' button active until cancelled (#967) * LIMS-1799: Checks for safety level should be case insensitive (#955) * LIMS-1786: Add Dewars column to Shipments page (#958) * LIMS-1426: Allow setting of pipeline when ranking samples (#950) * LIMS-1783: Add parent container dropdown for gridboxes (#965) * LIMS-1903: Fix display of shipping labels (#984)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1799
Summary:
#827 introduced a check on the shipment safety level, for queueing containers, but the check was case sensitive. This makes it case-insensitive as the field is text, not an enum.
Also fix a couple of minor things that github complains about in PRs.
Changes:
Object.prototype.hasOwnProperty.callinsteadthis.$instead of$in viewsTo test: