Skip to content

LIMS-1425: Show samples with no processing as grey#820

Merged
ndg63276 merged 1 commit intopre-release/2024-R4.3from
fix/LIMS-1425/show-samples-with-no-processing-as-grey
Sep 17, 2024
Merged

LIMS-1425: Show samples with no processing as grey#820
ndg63276 merged 1 commit intopre-release/2024-R4.3from
fix/LIMS-1425/show-samples-with-no-processing-as-grey

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-1425

Summary:

When ranking samples on a plate by autoprocessing (AP) resolution or completeness, any samples with failed autoprocessing are currently displayed as yellow. This is confusing, they should just be grey, as for samples without any data.

Changes:

  • Dont show any samples as 'yellow', just use #dfdfdf (grey) for all.

To test:

  • Go to a plate eg /containers/cid/309483, change the "Display" radio button to "Data Status"
  • Take a note of which wells are shown in blue, this means the autoprocessing failed, and which are green, this means the autoprocessing succeeded
  • Tick the "Rank By" checkbox, and check the blue wells turn grey, not yellow
  • Check the green wells turn red/orange/green as before

@gfrn gfrn self-requested a review August 27, 2024 09:28
@gfrn gfrn added javascript Pull requests that update Javascript code Ready to Release labels Aug 27, 2024
@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R4.3 September 17, 2024 09:01
@ndg63276 ndg63276 merged commit c97d77f into pre-release/2024-R4.3 Sep 17, 2024
ndg63276 added a commit that referenced this pull request Oct 1, 2024
* LIMS-1368: Fix incorrectly summed dose for DC groups when filtered (#803)

* LIMS-1099: Limit what can be done with red proteins (#827)

* LIMS-14: Show a direct link to the autoprocessing log (#805)

* LIMS-1422: Reprocessing dialog edits the end value unpredictably (#819)

* LIMS-1424: Show visit for each container if set (#828)

* LIMS-1425: Show samples with no processing as grey (#820)
@ndg63276 ndg63276 deleted the fix/LIMS-1425/show-samples-with-no-processing-as-grey branch October 1, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code Ready to Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants