LIMS-1379: Grid scan heatmaps are not snaked correctly#800
Merged
ndg63276 merged 1 commit intopre-release/2024-R4.1from Aug 16, 2024
Merged
Conversation
gfrn
approved these changes
Jul 17, 2024
ndg63276
added a commit
that referenced
this pull request
Sep 3, 2024
* LIMS-1355: Make OAuth2 support more generic (#792) * LIMS-1383, LIMS-160, LIMS-269: Improve reprocessing (#812) * LIMS-1379: Grid scan heatmaps are not snaked correctly (#800) * LIMS-1119: Show text on small buttons (#798) * LIMS-700: Allow bulk editing of protein (#808) * LIMS-1371, LIMS-1372: Add search and 'My Groups' to Sample Groups page (#579)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1379
Summary:
You can view heatmaps for grid scans on plates via the container view, eg https://ispyb.diamond.ac.uk/containers/cid/295986 well 3. But the snaked parameter is being ignored, so alternate rows of the grid scan are flipped from what they should be. This creates a stripy and mirrored effect.
Changes:
=== 1(see here)To test: