Skip to content

LIMS-1119: Show text on small buttons#798

Merged
ndg63276 merged 3 commits intopre-release/2024-R4.1from
improvement/LIMS-1119/show-text-on-small-buttons
Aug 16, 2024
Merged

LIMS-1119: Show text on small buttons#798
ndg63276 merged 3 commits intopre-release/2024-R4.1from
improvement/LIMS-1119/show-text-on-small-buttons

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

@ndg63276 ndg63276 commented Jul 3, 2024

JIRA ticket: LIMS-1119

Summary:

Some users struggle to request their dewar be dispatched, so lets put some labels on the buttons, if the screen is wide enough.

Changes:

  • Remove the big "Add Container" button, it is not clear which dewar that adds it to
  • Display labels for buttons for "Deactivate", "Print Report", "Add Container", "Dispatch" and "Transfer".
  • Make the "Add to Project" button on Samples and Proteins pages have a label as well.

To test:

  • Go to a shipment that is in the dewar store, check the 4 buttons "Print Report", "Add Container", "Dispatch" and "Transfer" appear with labels.
  • Go to a shipment that is "processing", check the extra "Deactivate" button appears with a label.
  • Go to a shipment that is at "Stores-out", check the "Dispatch" and "Transfer" buttons don't appear.
  • Check each button works as expected ("Print Report" sometimes takes a few attempts)
  • Check the labels disappear when the window is less wide.
  • Go to a shipment on the i15-1 commissioning proposal, check the "Add Container" button now says "Add Puck".
  • Go to the /samples and /proteins pages, check each sample/protein has a link to add to a project with a suitable label, check the button works, check the label disappears if the window gets smaller.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R4.1 August 16, 2024 12:45
@ndg63276 ndg63276 merged commit ac5a293 into pre-release/2024-R4.1 Aug 16, 2024
@ndg63276 ndg63276 deleted the improvement/LIMS-1119/show-text-on-small-buttons branch August 27, 2024 09:25
ndg63276 added a commit that referenced this pull request Sep 3, 2024
* LIMS-1355: Make OAuth2 support more generic (#792)

* LIMS-1383, LIMS-160, LIMS-269: Improve reprocessing (#812)

* LIMS-1379: Grid scan heatmaps are not snaked correctly (#800)

* LIMS-1119: Show text on small buttons (#798)

* LIMS-700: Allow bulk editing of protein (#808)

* LIMS-1371, LIMS-1372: Add search and 'My Groups' to Sample Groups page (#579)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants