LIMS-1246: Allow users with all_dewars permission to view all shipments#752
Merged
ndg63276 merged 3 commits intopre-release/2024-R3.1from Jun 25, 2024
Conversation
Collaborator
|
Not that performant on local, but works fine when deployed. |
ndg63276
added a commit
that referenced
this pull request
Jul 3, 2024
* LIMS-595: Change Sample Changers/Containers/Stage to Pucks for i15/i15-1 (xpdf) (#579) * LIMS-67: Fix 2 slow queries on imaging admin dashboard (#751) * LIMS-1334: Allow selection of plate samples already in a group (#778) * LIMS-1246: Allow users with all_dewars permission to view all shipments (#752) * LIMS-1351: Switch to simpler arrows (#787) * LIMS-1343: Interface changes based on reviewer suggestions from Conexs paper (#783) * LIMS-1170: Dont use thumbnails for crystal snapshots (#784)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1246
Summary:
Members of goods handling have the "all_dewars" permission in ISPyB. We should allow them to see all shipments, and print the shipping labels. They should also see the "Logistics" page (/dewars/overview) with the truck icon in the top right.
Unfortunately this PR also allows them to see:
Does not allow them to see:
Changes:
To test: