Skip to content

Display message for null FedIDs#1056

Merged
ndg63276 merged 3 commits intopre-release/2026-R2.1from
fix/display-message-for-null-fedid
Mar 24, 2026
Merged

Display message for null FedIDs#1056
ndg63276 merged 3 commits intopre-release/2026-R2.1from
fix/display-message-for-null-fedid

Conversation

@gfrn
Copy link
Copy Markdown
Collaborator

@gfrn gfrn commented Mar 24, 2026

Summary:

This displays a descriptive error message for those who logged in with an email and got a null FedID back (because they don't have FedIDs yet)

Changes:

  • Display message for null FedIDs

To test:

  • Log in with a test Keycloak user that has no FedID (or modify getUser in the authentication method you're using, so it always returns null)
  • Check if a message asking you to log in with your FedID is displayed
  • Repeat by logging with your FedID (if you modified getUser, undo your changes), check if you can log in as normal

@gfrn gfrn self-assigned this Mar 24, 2026
@gfrn gfrn added bug php Pull requests that update PHP code labels Mar 24, 2026
@ndg63276 ndg63276 self-requested a review March 24, 2026 15:24
@ndg63276 ndg63276 changed the base branch from master to pre-release/2026-R2.1 March 24, 2026 15:26
@ndg63276 ndg63276 merged commit 6d234f7 into pre-release/2026-R2.1 Mar 24, 2026
2 checks passed
@ndg63276 ndg63276 deleted the fix/display-message-for-null-fedid branch March 24, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug php Pull requests that update PHP code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants