Skip to content

LIMS-2129: Fix permissions for Goods Handling#1042

Merged
ndg63276 merged 1 commit intopre-release/2026-R2.1from
fix/LIMS-2129/fix-permissions-for-goods-handling
Mar 24, 2026
Merged

LIMS-2129: Fix permissions for Goods Handling#1042
ndg63276 merged 1 commit intopre-release/2026-R2.1from
fix/LIMS-2129/fix-permissions-for-goods-handling

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

@ndg63276 ndg63276 commented Mar 4, 2026

JIRA ticket: LIMS-2129

Summary:

All members of DLS staff have been added to the group b01-1_admin and thus Synchweb treats them as staff, which means we were never testing whether they had all_dewars permission, as #752 was not well written.

Changes:

  • Swap the order of if clauses to test the all_dewars permission first

To test:

  • Log in as someone from goods handling, test you can navigate via a proposal to a shipment and print shipping labels
  • Test a direct link to a shipment as someone from goods handling
  • Test you cannot see visits or data collections
  • Log in as a 'normal' user, test you can only get to shipments from your proposal
  • Test a direct link to a shipment you should not be able to see
  • Log in as staff, test you can see everything as normal

@ndg63276 ndg63276 changed the base branch from master to pre-release/2026-R2.1 March 24, 2026 10:17
@ndg63276 ndg63276 merged commit 9f072d9 into pre-release/2026-R2.1 Mar 24, 2026
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-2129/fix-permissions-for-goods-handling branch March 24, 2026 10:25
ndg63276 added a commit that referenced this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants