Skip to content

LIMS-2059: Re-enable reprocess button after any parameter change#1031

Merged
ndg63276 merged 1 commit intopre-release/2026-R1.5from
improvement/LIMS-2059/re-enable-reprocess-button-quicker
Mar 3, 2026
Merged

LIMS-2059: Re-enable reprocess button after any parameter change#1031
ndg63276 merged 1 commit intopre-release/2026-R1.5from
improvement/LIMS-2059/re-enable-reprocess-button-quicker

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

@ndg63276 ndg63276 commented Feb 6, 2026

JIRA ticket: LIMS-2059

Summary:

#1009 introduced a 5s delay after pushing the reprocessing 'submit' button, to prevent accidental double clicks. This seems very long if you want to submit multiple similar jobs, so the button should re-enable if you change something.

Changes:

  • Make re-enabling the button it's own function
  • Trigger that function after 5s or if any input or select elements are changed
  • Do this for normal reprocessing, downstream reprocessing or multicrystal reprocessing

To test:

  • Use the live database as otherwise the reprocessing jobs will not exist as zocalo expects and may cause problems. Alternatively, comment out the _enqueue functions in these files.
  • Go to a data collection with some automatic processing, eg /dc/visit/mx23694-154/id/21536724
  • Click the small cog item to open the "Reprocess Data" window
  • Click Integrate, and check the Integrate button is disabled for 5s
  • Click Integrate again, and then change a parameter, eg the pipeline or the high res limit, the Integrate button should be enabled again
  • Close that window and view an existing Autoprocessing job. Click the "Downstream Processing" button, and then repeat the above tests with the "Submit" button
  • Go to the multicrystal reprocessing page /mc/visit/mx23694-154, and click the crossed arrows next to a data collection to select it. Repeat the above tests with the "Integrate" button.

@gfrn
Copy link
Copy Markdown
Collaborator

gfrn commented Feb 10, 2026

Nitpick of nitpicks, but even if firing off reprocessing fails, the button is still disabled for 5 seconds. Not that it matters much, don't think anyone will mind.

Happy to approve otherwise!

@ndg63276
Copy link
Copy Markdown
Collaborator Author

Nitpick of nitpicks, but even if firing off reprocessing fails, the button is still disabled for 5 seconds. Not that it matters much, don't think anyone will mind.

Happy to approve otherwise!

True. But if it does fail, you probably dont want someone hammering the button!

@ndg63276 ndg63276 changed the base branch from master to pre-release/2026-R1.5 March 3, 2026 10:47
@ndg63276 ndg63276 merged commit 6339e7d into pre-release/2026-R1.5 Mar 3, 2026
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-2059/re-enable-reprocess-button-quicker branch March 3, 2026 10:52
ndg63276 added a commit that referenced this pull request Mar 24, 2026
* LIMS-2104: Fix autoproc labels on mobile (#1033)

* LIMS-2064: Show no of pucks/plates on shipments page (#1038)

* LIMS-2059: Reenable reprocess button after any parameter change (#1031)

* LIMS-2054: Dont exclude peaks from MCA spectra (#1036)

* LIMS-2044: Remove luxon (#1022)

* LIMS-2031: Add toggle to expand data collection groups (#1028)

* Fix display of individual fluorescence scans and spectra

* LIMS-2023: Add Basic Auth to UAS for UDC (#1048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants