Skip to content

LIMS-2044: Remove luxon#1022

Merged
ndg63276 merged 2 commits intopre-release/2026-R1.5from
improvement/LIMS-2044/update-luxon
Mar 3, 2026
Merged

LIMS-2044: Remove luxon#1022
ndg63276 merged 2 commits intopre-release/2026-R1.5from
improvement/LIMS-2044/update-luxon

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

@ndg63276 ndg63276 commented Jan 16, 2026

JIRA ticket: LIMS-2044

Summary:

Remove the luxon library.

Changes:

  • Remove luxon from package.json and package-lock.json
  • Convert calendar functions to native JS
  • Use native JS and don't worry about time zones when calculating length of visits (this would seem to mostly apply to creating visits in Synchweb, which we don't do, but the code is called by various pages)
  • Fix a rogue missing comma I found
  • Add a new linting rule as we are ignoring it anyway

To test:

  • View the list of visits for a proposal, check no errors occur
  • View the data collection page, check no errors occur
  • View the calendar page, check no errors, check days of the week, check days in the month etc.
  • (Dev DB only) Go to the 'Add New Visit' page at eg /admin/proposals/visit/add/mx23694, check you can add a new visit

@gfrn
Copy link
Copy Markdown
Collaborator

gfrn commented Jan 20, 2026

Any chance we can remove Luxon altogether? Seems like it's being used in only 2 places

@ndg63276 ndg63276 changed the title LIMS-2044: Update luxon LIMS-2044: Remove luxon Jan 21, 2026
@ndg63276 ndg63276 requested a review from gfrn January 21, 2026 17:30
@ndg63276 ndg63276 changed the base branch from master to pre-release/2026-R1.5 March 3, 2026 10:47
@ndg63276 ndg63276 merged commit 2cc666f into pre-release/2026-R1.5 Mar 3, 2026
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-2044/update-luxon branch March 3, 2026 10:52
ndg63276 added a commit that referenced this pull request Mar 24, 2026
* LIMS-2104: Fix autoproc labels on mobile (#1033)

* LIMS-2064: Show no of pucks/plates on shipments page (#1038)

* LIMS-2059: Reenable reprocess button after any parameter change (#1031)

* LIMS-2054: Dont exclude peaks from MCA spectra (#1036)

* LIMS-2044: Remove luxon (#1022)

* LIMS-2031: Add toggle to expand data collection groups (#1028)

* Fix display of individual fluorescence scans and spectra

* LIMS-2023: Add Basic Auth to UAS for UDC (#1048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants