Skip to content

LIMS-1962: Allow downloading of html files#1006

Merged
ndg63276 merged 3 commits intopre-release/2025-R5.3from
improvement/LIMS-1962/allow-downloading-of-html-files
Nov 24, 2025
Merged

LIMS-1962: Allow downloading of html files#1006
ndg63276 merged 3 commits intopre-release/2025-R5.3from
improvement/LIMS-1962/allow-downloading-of-html-files

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

@ndg63276 ndg63276 commented Nov 14, 2025

JIRA ticket: LIMS-1962

Summary:

The Download button sometimes opens attachments in the current tab, we should allow explicit downloading or opening.

Changes:

  • Add an 'Open' button to log files, which opens the file in the browser tab
  • Make the 'Download' button always download the file
  • Display .lst files as plain text

To test:

  • Go to any data collection with auto processing results, then open the Auto Processing bar
  • Click the Logs & Files dialog. Checkl each file of type "Log" has 3 buttons
  • Check the Download button downloads the file to your hard disk, that the Open button opens the file in the browser tab, and the View button opens it in a frame
  • Zip one of the files, keeping but renaming the original (to preserve permissions), and check it behaves the same, then undo the renaming after, eg
gzip -k xia2.html
mv xia2.html xia2.original
# test Synchweb still works as expected
mv xia2.original xia2.html
rm xia2.html.gz
  • Find a Fast EP ersult, check you can do Open on a .lst file

Co-authored-by: Guilherme Francisco <[email protected]>
@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R5.3 November 24, 2025 16:54
@ndg63276 ndg63276 merged commit 70ce114 into pre-release/2025-R5.3 Nov 24, 2025
1 of 2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1962/allow-downloading-of-html-files branch November 24, 2025 17:00
ndg63276 added a commit that referenced this pull request Dec 5, 2025
* LIMS-1983: Update phpCAS and php-jwt (#1005)

* LIMS-1970: Fix Logs & Files view if filepath is null (#1004)

* LIMS-1962: Allow downloading of html files (#1006)

* LIMS-1431 - Display Metal Id downstream pipeline (#1003)

* LIMS-1854: Prevent submission of multiple reprocessing jobs (#1009)

* LIMS-1956: Add dewar names and serial nos to shipment requests (#1000)

* Fix unit tests (#1015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants