Skip to content

LIMS-1970: Fix Logs & Files view if filepath is null#1004

Merged
ndg63276 merged 3 commits intopre-release/2025-R5.3from
fix/LIMS-1970/logs-and-files-fails-if-path-is-null
Nov 24, 2025
Merged

LIMS-1970: Fix Logs & Files view if filepath is null#1004
ndg63276 merged 3 commits intopre-release/2025-R5.3from
fix/LIMS-1970/logs-and-files-fails-if-path-is-null

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-1970

Summary:

If the AutoProcProgramAttachment.filePath is null, the Logs & Files view doesn't open.

Changes:

  • Always create a filePath variable even if it is an empty string

To test:

  • Go to a data collection with auto processing attachments with null filePaths (eg /dc/visit/mx1223-3/id/69220)
  • Click on the Auto Processing bar, then open the Logs & Files view, check it shows a couple of attachments, although the path is empty

Co-authored-by: Guilherme Francisco <[email protected]>
@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R5.3 November 24, 2025 16:54
@ndg63276 ndg63276 merged commit 446e9fb into pre-release/2025-R5.3 Nov 24, 2025
1 of 2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1970/logs-and-files-fails-if-path-is-null branch November 24, 2025 17:00
ndg63276 added a commit that referenced this pull request Dec 5, 2025
* LIMS-1983: Update phpCAS and php-jwt (#1005)

* LIMS-1970: Fix Logs & Files view if filepath is null (#1004)

* LIMS-1962: Allow downloading of html files (#1006)

* LIMS-1431 - Display Metal Id downstream pipeline (#1003)

* LIMS-1854: Prevent submission of multiple reprocessing jobs (#1009)

* LIMS-1956: Add dewar names and serial nos to shipment requests (#1000)

* Fix unit tests (#1015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants