Skip to content

LIMS-1431 - Display Metal Id downstream pipeline#1003

Merged
ndg63276 merged 6 commits intopre-release/2025-R5.3from
improvement/LIMS-1431/display-metal-id-processing
Nov 24, 2025
Merged

LIMS-1431 - Display Metal Id downstream pipeline#1003
ndg63276 merged 6 commits intopre-release/2025-R5.3from
improvement/LIMS-1431/display-metal-id-processing

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-1431

Summary:

Display results from the new "Metal Id" downstream pipeline.

Changes:

  • Add Metal Id has a a possible pipeline
  • Add Metal Id template, with basic image viewing
  • Add code to hide "View Map / Model" button if the pipeline $has_mapmodel set to (0,0)
  • Provide backend for getting results from database, with number of images, coping with zero peaks etc
  • Fix method of finding MXMRRunId for Dimple

To test:

  • Go to a data collection with metal id results eg /dc/visit/nr29467-86/id/20056924
  • Expand the downstream processing bar, and switch to the Metal Id tab
  • Check that the peaks shown match those in the database (NB may not match log file as there was a bug in the analysis team's code)
  • Check each peak has an image and that you can click between images
  • Check if there are no peaks in the database there is a message saying "No peaks found"
  • Check if the job failed there is a message saying so
  • Check there is no "View Map / Model" button
  • Check the View Upstream button works as expected
  • Check the Dimple tab looks ok

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R5.3 November 24, 2025 16:55
@ndg63276 ndg63276 merged commit 5f882f9 into pre-release/2025-R5.3 Nov 24, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1431/display-metal-id-processing branch November 24, 2025 17:00
ndg63276 added a commit that referenced this pull request Dec 5, 2025
* LIMS-1983: Update phpCAS and php-jwt (#1005)

* LIMS-1970: Fix Logs & Files view if filepath is null (#1004)

* LIMS-1962: Allow downloading of html files (#1006)

* LIMS-1431 - Display Metal Id downstream pipeline (#1003)

* LIMS-1854: Prevent submission of multiple reprocessing jobs (#1009)

* LIMS-1956: Add dewar names and serial nos to shipment requests (#1000)

* Fix unit tests (#1015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants