Closed
Conversation
Member
|
@AlanLee97 这波重构是真的强！ |
Collaborator
Author
抱歉，kagol哥，又一次性提交这么多代码🤣（我是想着把这个功能完成一起提交PR） |
Member
@AlanLee97 建议将这个PR按照重构的模块进行拆分，保持PR的粒度在100行代码左右，每个PR都是MVP。拆分PR的过程也是学习编写高质量、可读代码的过程，欢迎一起讨论~ |
Member
|
@all-contributors please add @AlanLee97 for code |
Contributor
|
I've put up a pull request to add @AlanLee97! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor:
fix:
docs: