Repository navigation
Fix build error with libgit2 -Wmissing-field-initializers - #91
Merged
Merged
Conversation
Build fails at pass_githistory.c:171 with:
error: missing field 'interhunk_lines' initializer
[-Werror,-Wmissing-field-initializers]
git_diff_options diff_opts = GIT_DIFF_OPTIONS_INIT;
codebase-memory-mcp at 75b5dcb has this issue. The GIT_DIFF_OPTIONS_INIT
macro does not list all struct fields, which clang flags as an error
under -Werror.
Replace the macro with the runtime git_diff_options_init() API, which
properly initializes all fields. Available since libgit2 0.28.
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Owner
ngallodev
added a commit
to ngallodev/codebase-memory-cli
that referenced
this pull request
Nov 9, 2026
…ok installer Jenkins DeusData#91 failed two tests added by upstream DeusData#1862 follow-up e8f0f4a: cli_hermes_hook_reinstalls_after_uninstall_empties_hooks and cli_hermes_hook_cycle_keeps_foreign_pre_llm_hook. Two fork differences caused it: - In this fork, `install` writes agent instructions and skills only; hooks come from `install-hooks`. The tests called cbm_install_agent_configs, which never writes the Hermes pre_llm_call hook here. They now call cbm_install_agent_hooks_for_testing, the same entry point the existing cli_hermes_stable_shell_context_contract test uses. - The fixture named the binary codebase-memory-mcp. The fork's uninstall identifies its owned hook by the codebase-memory-cli binary name, so it treated the upstream-named entry as user-modified and kept it. The fixture now uses codebase-memory-cli. The assertions are unchanged: one owned hook after install, `hooks: {}` accepted on uninstall/reinstall, and a foreign hook restored byte for byte. Locally all three Hermes hook tests pass.
ngallodev
added a commit
to ngallodev/codebase-memory-cli
that referenced
this pull request
Nov 9, 2026
…ification Adds per-batch receipts (13m1.md, 13m2.md, 13n.md) and updates ledger.json, PLAN.md and CONTINUE.md for the 2026-11-08 upstream closeout against DeusData 612eee2. Jenkins release-tooling full gate, exact heads: - 13M-1 c3c5271: DeusData#90 SUCCESS; merged to main via PR #33 (929adfe). DeusData#89 on 3cbefe2 failed only on the index_policy fixture fixed there. - 13M-2 0f1927f: DeusData#93 SUCCESS. DeusData#91 on 1c5f82a failed two upstream Hermes hook cycle tests, fixed in 0f1927f. - 13N 98eab3c: DeusData#94 SUCCESS. DeusData#92 on cf24b6a was aborted because that head lacked the 13M-2 test fix. Native Windows was not run for any batch, so the reserved-`nul` change (DeusData#2903) is unverified on Windows. This commit only touches docs; the code Jenkins qualified is 98eab3c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pass_githistory.c:171with-Werror,-Wmissing-field-initializersbecauseGIT_DIFF_OPTIONS_INITmacro doesn't list all struct fieldsgit_diff_options_init()runtime API, which properly initializes all fieldsgit_diff_options_init()available since libgit2 0.28 (2019)Test plan
scripts/build.shcompletes without errorsFixes #104
🤖 Generated with Claude Code