Skip to content

Commit babc3d8

Browse files
committed
revert(guards): drop the unverified launcher-guard edits
Neither the fresh portable pair nor the ownership stamp fixed the immediate managed reinstall, so both were guesses and do not belong on a release-blocking PR. The guard's failure is pre-existing on main -- byte-identical output there, and unchanged with the #581 fix disabled -- so this branch carries no regression and no speculative test edits either. What the investigation did establish: the reinstall's install command fails with 'managed install requires a verified adjacent codebase-memory-mcp.exe launcher' when run directly, and emits no diagnostic on the stream the guard captures, which is why the guard reports only a version banner. Signed-off-by: Martin Vogel <[email protected]>
1 parent e547de5 commit babc3d8

1 file changed

Lines changed: 1 addition & 17 deletions

File tree

‎tests/windows/test_windows_launcher.py‎

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1566,24 +1566,8 @@ def main():
15661566
source_launcher, source_payload, launcher, env, cache, work
15671567
)
15681568
assert_failed_uninstall_restores_state(launcher, managed_dir, env)
1569-
# Stage a FRESH portable pair: the earlier managed installs consume the
1570-
# launcher sitting beside work/portable-install's payload, and a managed
1571-
# install legitimately refuses a payload with no verified adjacent
1572-
# launcher ("managed install requires a verified adjacent
1573-
# codebase-memory-mcp.exe launcher"). Reusing the consumed pair made this
1574-
# guard fail on the product's correct behaviour rather than on the
1575-
# immediate-reinstall contract it exists to protect.
1576-
reinstall_dir = work / "portable-reinstall"
1577-
_, reinstall_payload = copy_portable_pair(
1578-
source_launcher, source_payload, reinstall_dir
1579-
)
1580-
# Copied files inherit Administrators ownership on runner images, and the
1581-
# launcher's exact-owner validators (correctly) require the current user
1582-
# -- so an unstamped pair is refused as unverified, which is the same
1583-
# error as having no adjacent launcher at all.
1584-
stamp_fixture_owner_current(reinstall_dir, env)
15851569
assert_uninstall_immediate_reinstall_safe(
1586-
launcher, managed_dir, reinstall_payload, env
1570+
launcher, managed_dir, portable_payload, env
15871571
)
15881572
print("\nGREEN: permanent Windows launcher contract honored.")
15891573
return 0

0 commit comments

Comments
 (0)