Repository navigation
Commit aa4775f
committed
test(doc_links_pdf): receiver-qualified Go method nodes (#1913)
Two PDF doc-link tests named a Go method by its flat QN. With #1913 a
Go method's QN carries its receiver, so the lookups found no node.
The resolver is unchanged: for a Go method, rel(parent_class).name now
equals the QN, so the method binds through its QN, like a member of
any other language.
- pdf_links_pipeline: page 1 names `server.Handler.Serve`; the edge
target pkg.server.Serve becomes pkg.server.Handler.Serve. Same
assertions: pdf_qn syntax, unique tier.
- pdf_qn_method_through_owner, page 2: `time.Provider.Now` binds
pkg.time.Provider.Now (was pkg.time.Now), syntax pdf_qn.
- pdf_qn_method_through_owner, page 1: `time.Now` must not bind the
method. The target moves to pkg.time.Provider.Now too. Against the
old flat QN, no node exists any more, so the zero count would have
passed vacuously. The page 2 assertion proves that the node exists.
The ownerless-QN rule in doc_links_pdf.c stays: a templ method keeps
the flat package QN while it carries parent_class (extract_defs.c only
receiver-qualifies CBM_LANG_GO). Its comment no longer says that Go
methods have no receiver.
Signed-off-by: Martin Vogel <[email protected]>1 parent 4e2dcd5 commit aa4775f
2 files changed
Lines changed: 13 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
328 | 328 | | |
329 | 329 | | |
330 | 330 | | |
331 | | - | |
332 | | - | |
333 | | - | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
334 | 335 | | |
335 | 336 | | |
336 | 337 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1087 | 1087 | | |
1088 | 1088 | | |
1089 | 1089 | | |
1090 | | - | |
1091 | | - | |
| 1090 | + | |
| 1091 | + | |
| 1092 | + | |
1092 | 1093 | | |
1093 | 1094 | | |
1094 | 1095 | | |
| |||
1142 | 1143 | | |
1143 | 1144 | | |
1144 | 1145 | | |
1145 | | - | |
| 1146 | + | |
1146 | 1147 | | |
1147 | 1148 | | |
1148 | | - | |
| 1149 | + | |
| 1150 | + | |
| 1151 | + | |
1149 | 1152 | | |
1150 | 1153 | | |
1151 | 1154 | | |
| |||
1169 | 1172 | | |
1170 | 1173 | | |
1171 | 1174 | | |
1172 | | - | |
| 1175 | + | |
1173 | 1176 | | |
1174 | | - | |
| 1177 | + | |
1175 | 1178 | | |
1176 | 1179 | | |
1177 | 1180 | | |
| |||
0 commit comments