Skip to content

Commit 7808eee

Browse files
committed
revert(daemon): drop the connection thread pool
Reverts 3cd1d33. It was built on the theory that per-connection thread-heap churn drove #581, and the measurements later falsified that: growth scaled with requests rather than threads, and the real cause was thread heaps never being released at all, fixed separately by the TLS detach callback. It also broke a Windows regression guard -- test_daemon_stability section_cold_storm, 'a fixed Windows bug is broken again' -- which is what concurrent clients racing to spawn a daemon do to reworked reaping and shutdown ordering. A concurrency rewrite that fixes nothing it claimed and reopens a closed bug does not belong in a release-blocking PR. The allocator thread-heap fix is untouched. Signed-off-by: Martin Vogel <[email protected]>
1 parent 3c3f043 commit 7808eee

81 files changed

Lines changed: 14722 additions & 169 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎memlab-linux.jsonl‎

Lines changed: 977 additions & 0 deletions
Large diffs are not rendered by default.

‎memlab-linux.log‎

Lines changed: 411 additions & 0 deletions
Large diffs are not rendered by default.

‎memlab-mac.jsonl‎

Lines changed: 103 additions & 0 deletions
Large diffs are not rendered by default.

‎memlab-mac.log‎

Lines changed: 211 additions & 0 deletions
Large diffs are not rendered by default.

‎soak-mac-fixed/cbm-daemon.log‎

Lines changed: 181 additions & 0 deletions
Large diffs are not rendered by default.

‎soak-mac-fixed/cli-churn-stderr.log‎

Lines changed: 120 additions & 0 deletions
Large diffs are not rendered by default.

‎soak-mac-fixed/latency.csv‎

Lines changed: 168 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,168 @@
1+
timestamp,tool,duration_ms,exit_code
2+
1785015357,index_repository,1385,0
3+
1785015363,search_graph,43,0
4+
1785015363,trace_path,33,0
5+
1785015365,index_repository,1333,0
6+
1785015367,search_graph,50,0
7+
1785015367,trace_path,38,0
8+
1785015369,search_graph,51,0
9+
1785015369,trace_path,42,0
10+
1785015371,search_graph,50,0
11+
1785015371,trace_path,51,0
12+
1785015373,search_graph,44,0
13+
1785015373,trace_path,47,0
14+
1785015376,search_graph,45,0
15+
1785015376,trace_path,34,0
16+
1785015378,search_graph,44,0
17+
1785015378,trace_path,46,0
18+
1785015380,search_graph,46,0
19+
1785015380,trace_path,36,0
20+
1785015382,search_graph,50,0
21+
1785015382,trace_path,38,0
22+
1785015384,search_graph,46,0
23+
1785015384,trace_path,41,0
24+
1785015386,search_graph,51,0
25+
1785015386,trace_path,50,0
26+
1785015389,search_graph,48,0
27+
1785015389,trace_path,39,0
28+
1785015391,search_graph,57,0
29+
1785015391,trace_path,43,0
30+
1785015393,search_graph,40,0
31+
1785015393,trace_path,45,0
32+
1785015395,search_graph,50,0
33+
1785015395,trace_path,39,0
34+
1785015397,search_graph,55,0
35+
1785015397,trace_path,47,0
36+
1785015399,search_graph,52,0
37+
1785015399,trace_path,43,0
38+
1785015401,search_graph,43,0
39+
1785015402,trace_path,49,0
40+
1785015404,search_graph,49,0
41+
1785015404,trace_path,36,0
42+
1785015406,search_graph,51,0
43+
1785015406,trace_path,33,0
44+
1785015408,search_graph,45,0
45+
1785015408,trace_path,47,0
46+
1785015410,search_graph,50,0
47+
1785015410,trace_path,41,0
48+
1785015412,search_graph,46,0
49+
1785015412,trace_path,44,0
50+
1785015414,search_graph,52,0
51+
1785015414,trace_path,47,0
52+
1785015417,search_graph,42,0
53+
1785015417,trace_path,46,0
54+
1785015419,search_graph,53,0
55+
1785015419,trace_path,40,0
56+
1785015421,search_graph,48,0
57+
1785015421,trace_path,45,0
58+
1785015423,search_graph,52,0
59+
1785015423,trace_path,40,0
60+
1785015425,search_graph,55,0
61+
1785015425,trace_path,36,0
62+
1785015427,search_graph,51,0
63+
1785015427,trace_path,35,0
64+
1785015430,search_graph,46,0
65+
1785015430,trace_path,40,0
66+
1785015432,search_graph,42,0
67+
1785015432,trace_path,50,0
68+
1785015434,search_graph,54,0
69+
1785015434,trace_path,38,0
70+
1785015436,search_graph,53,0
71+
1785015436,trace_path,47,0
72+
1785015438,search_graph,41,0
73+
1785015438,trace_path,48,0
74+
1785015440,search_graph,44,0
75+
1785015440,trace_path,50,0
76+
1785015443,search_graph,46,0
77+
1785015443,trace_path,34,0
78+
1785015445,search_graph,45,0
79+
1785015445,trace_path,47,0
80+
1785015447,search_graph,51,0
81+
1785015447,trace_path,43,0
82+
1785015449,search_graph,46,0
83+
1785015449,trace_path,38,0
84+
1785015451,search_graph,57,0
85+
1785015451,trace_path,42,0
86+
1785015453,search_graph,44,0
87+
1785015453,trace_path,39,0
88+
1785015455,search_graph,44,0
89+
1785015456,trace_path,41,0
90+
1785015458,search_graph,52,0
91+
1785015458,trace_path,42,0
92+
1785015460,search_graph,48,0
93+
1785015460,trace_path,37,0
94+
1785015462,search_graph,45,0
95+
1785015462,trace_path,44,0
96+
1785015464,search_graph,60,0
97+
1785015464,trace_path,32,0
98+
1785015466,search_graph,51,0
99+
1785015466,trace_path,35,0
100+
1785015468,search_graph,45,0
101+
1785015468,trace_path,39,0
102+
1785015471,search_graph,57,0
103+
1785015471,trace_path,43,0
104+
1785015473,search_graph,50,0
105+
1785015473,trace_path,47,0
106+
1785015475,search_graph,49,0
107+
1785015475,trace_path,45,0
108+
1785015477,search_graph,53,0
109+
1785015477,trace_path,48,0
110+
1785015479,search_graph,50,0
111+
1785015479,trace_path,40,0
112+
1785015481,search_graph,38,0
113+
1785015481,trace_path,45,0
114+
1785015484,search_graph,51,0
115+
1785015484,trace_path,40,0
116+
1785015485,index_repository,1335,0
117+
1785015487,search_graph,49,0
118+
1785015487,trace_path,39,0
119+
1785015489,search_graph,49,0
120+
1785015489,trace_path,46,0
121+
1785015491,search_graph,51,0
122+
1785015491,trace_path,48,0
123+
1785015494,search_graph,46,0
124+
1785015494,trace_path,39,0
125+
1785015496,search_graph,42,0
126+
1785015496,trace_path,42,0
127+
1785015498,search_graph,39,0
128+
1785015498,trace_path,48,0
129+
1785015500,search_graph,52,0
130+
1785015500,trace_path,48,0
131+
1785015502,search_graph,54,0
132+
1785015502,trace_path,36,0
133+
1785015504,search_graph,54,0
134+
1785015504,trace_path,38,0
135+
1785015507,search_graph,52,0
136+
1785015507,trace_path,38,0
137+
1785015509,search_graph,52,0
138+
1785015509,trace_path,46,0
139+
1785015511,search_graph,56,0
140+
1785015511,trace_path,35,0
141+
1785015513,search_graph,39,0
142+
1785015513,trace_path,49,0
143+
1785015515,search_graph,53,0
144+
1785015515,trace_path,40,0
145+
1785015517,search_graph,49,0
146+
1785015517,trace_path,43,0
147+
1785015519,search_graph,48,0
148+
1785015520,trace_path,43,0
149+
1785015522,search_graph,47,0
150+
1785015522,trace_path,52,0
151+
1785015524,search_graph,45,0
152+
1785015524,trace_path,39,0
153+
1785015526,search_graph,54,0
154+
1785015526,trace_path,33,0
155+
1785015528,search_graph,46,0
156+
1785015528,trace_path,49,0
157+
1785015530,search_graph,51,0
158+
1785015530,trace_path,45,0
159+
1785015532,search_graph,47,0
160+
1785015532,trace_path,36,0
161+
1785015535,search_graph,42,0
162+
1785015535,trace_path,38,0
163+
1785015537,search_graph,45,0
164+
1785015537,trace_path,47,0
165+
1785015539,search_graph,56,0
166+
1785015539,trace_path,46,0
167+
1785015541,search_graph,42,0
168+
1785015541,trace_path,35,0

‎soak-mac-fixed/metrics.csv‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
timestamp,uptime_s,rss_bytes,heap_committed,fd_count,query_count,query_max_us
2+
1785015363,5,18661376,11534336,17,1,1345164
3+
1785015373,15,19496960,11534336,17,8,1345164
4+
1785015384,25,19775488,11534336,17,18,1345164
5+
1785015395,35,19824640,11534336,17,28,1345164
6+
1785015406,50,19890176,11534336,17,41,1345164
7+
1785015417,60,19922944,11534336,17,50,1345164
8+
1785015427,70,19922944,11534336,17,60,1345164
9+
1785015438,80,19955712,11534336,17,68,1345164
10+
1785015449,90,19955712,11534336,17,78,1345164
11+
1785015460,100,19955712,11534336,17,88,1345164
12+
1785015471,110,19972096,11534336,17,96,1345164
13+
1785015481,125,19972096,11534336,17,110,1345164
14+
1785015494,135,20021248,11534336,17,119,1345164
15+
1785015504,145,20037632,11534336,17,129,1345164
16+
1785015515,155,20037632,11534336,17,138,1345164
17+
1785015526,170,20037632,11534336,17,151,1345164
18+
1785015537,180,20054016,11534336,17,161,1345164
19+
1785015573,215,20054016,11534336,17,167,1345164
20+
1785015621,260,20250624,11534336,17,167,1345164

‎soak-mac-fixed/server-stderr.log‎

Whitespace-only changes.

‎soak-mac-fixed/summary.txt‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
RSS: first=18MB last=19MB max=19MB (19 samples)
2+
RSS slope (post-warmup): 4522 KB/hr
3+
RSS ratio (last/first): 1,1x
4+
FD drift: 0
5+
Idle daemon CPU: 0,3%
6+
Max query latency: 60ms (index: 1385ms)
7+
Total queries: 167
8+
=== soak-test: PASSED ===

0 commit comments

Comments
 (0)