Skip to content

Commit 01af220

Browse files
committed
fix: replace raw remove()/rmdir() with cbm_unlink/cbm_rmdir in memory tests
Raw ANSI file operations break on non-ASCII Windows paths. The three remove() calls on memory_db and config_db paths in the manage_memory tests are replaced with cbm_unlink, and rmdir() with cbm_rmdir, matching the pattern used everywhere else in the test suite. Addresses reviewer feedback on PR #808.
1 parent dd19404 commit 01af220

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

‎tests/test_mcp.c‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7781,14 +7781,14 @@ TEST(tool_manage_memory_personal_store) {
77817781
cbm_mcp_server_free(srv);
77827782
cbm_config_close(cfg);
77837783
cbm_unsetenv("CBM_MEMORY_DIR");
7784-
remove(memory_db);
7785-
rmdir(memory_dir);
7784+
cbm_unlink(memory_db);
7785+
cbm_rmdir(memory_dir);
77867786
char config_db[512];
77877787
snprintf(config_db, sizeof(config_db), "%s/_config.db", cache_dir);
7788-
remove(config_db);
7789-
rmdir(cache_dir);
7790-
rmdir(repo_dir);
7791-
rmdir(tmp_dir);
7788+
cbm_unlink(config_db);
7789+
cbm_rmdir(cache_dir);
7790+
cbm_rmdir(repo_dir);
7791+
cbm_rmdir(tmp_dir);
77927792

77937793
PASS();
77947794
}
@@ -7869,9 +7869,9 @@ TEST(tool_manage_memory_rejects_repo_local_storage) {
78697869
cbm_unsetenv("CBM_MEMORY_DIR");
78707870
char config_db[512];
78717871
snprintf(config_db, sizeof(config_db), "%s/_config.db", cache_dir);
7872-
remove(config_db);
7873-
rmdir(cache_dir);
7874-
rmdir(tmp_dir);
7872+
cbm_unlink(config_db);
7873+
cbm_rmdir(cache_dir);
7874+
cbm_rmdir(tmp_dir);
78757875
PASS();
78767876
}
78777877

0 commit comments

Comments
 (0)