Merged
Conversation
WalkthroughCleanup in LocalStore::addToStore now always attempts to skip narSize and silence exceptions instead of parsing a dump; flake output formatting was simplified to print only the header and resolved string. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant LocalStore
participant Source
Caller->>LocalStore: addToStore(...)
alt previous flow (before)
LocalStore->>Source: attempt read (narRead false)
Note right of LocalStore: tried parseDump fallback\nwith NullFileSystemObjectSink
Source-->>LocalStore: read failure / skip not used
LocalStore->>LocalStore: parseDump(...) as fallback
else new flow (after)
LocalStore->>Source: call source.skip(narSize) within try
Source-->>LocalStore: may throw (ignored)
LocalStore->>Caller: cleanup complete
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Comment |
Changes
```
git+file:///home/eelco/Dev/nix
├───checks
│ ├───aarch64-darwin
│ │ ├───installerScriptForGHA: omitted 'omitted (use '--all-systems' to show)'
...
└───nix-util-tests-stdenv: derivation 'package 'nix-util-tests-3.11.3''
```
to
```
git+file:///home/eelco/Dev/nix
├───checks
│ ├───aarch64-darwin
│ │ ├───installerScriptForGHA: omitted (use '--all-systems' to show)
...
└───nix-util-tests-stdenv: package 'nix-util-tests-3.11.3'
```
edolstra
force-pushed
the
fix-flake-show-output
branch
from
f408f3b to
35a8e60
Compare
cole-h
approved these changes
Oct 23, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/libstore/local-store.cc(1 hunks)src/nix/flake.cc(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/libstore/local-store.cc (1)
src/libstore/dummy-store.cc (4)
source(186-250)source(186-193)info(160-184)info(160-160)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build_aarch64-darwin / build
- GitHub Check: build_x86_64-linux / build
🔇 Additional comments (1)
src/nix/flake.cc (1)
1385-1385: LGTM! Cleaner output format.The simplified format removes redundant type prefixes and extra quotes. The variable
salready contains the formatted string with appropriate context (e.g., "package 'name'" for derivations, full message for omitted items).
`skip()` can throw an exception, which we need to ignore since we may be unwinding an exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
to
Also includes a simplification to
LocalStore::addToStore().Context
Summary by CodeRabbit
Style
Refactor