Merged
Conversation
This change brings our Determinate Nix source repository in line with our standard branch naming.
One reason we used detsys-main was to avoid confusion in case the upstream NixOS/nix repository changed its default branch to main.
I don't anticipate that happening any time soon if ever, and so let's make the change.
Having this repo have a different branch name has a non-zero cost for humans ("oh right, different branch") and code to account for it.
Since we're shifting to internally run from `trunk()` (hi, jj) in more places, it's a "do it or don't" moment.
I choose to do it.
edolstra
approved these changes
Jul 31, 2025
cole-h
reviewed
Jul 31, 2025
Member
There was a problem hiding this comment.
You forgot to change the perpetual PR number on line 201. Fixed in #166.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This change brings our Determinate Nix source repository in line with our standard branch naming. One reason we used detsys-main was to avoid confusion in case the upstream NixOS/nix repository changed its default branch to main. I don't anticipate that happening any time soon if ever, and so let's make the change.
Context
Having this repo have a different branch name has a non-zero cost for humans ("oh right, different branch") and code to account for it.
Since we're shifting to internally run from
trunk()(hi, jj) in more places, it's a "do it or don't" moment. I choose to do it.