Add paths to the store asynchronously#162
Merged
edolstra merged 1 commit intodetsys-mainfrom Jul 28, 2025
Merged
Conversation
edolstra
force-pushed
the
async-path-writer
branch
from
87d1096 to
a1d86ad
Compare
edolstra
force-pushed
the
async-path-writer
branch
from
a1d86ad to
5b14ce0
Compare
cole-h
approved these changes
Jul 28, 2025
Member
cole-h
left a comment
cole-h
left a comment
There was a problem hiding this comment.
Needs a rebase now that the dependency PRs have merged, but otherwise LGTM I think.
Adding paths to the store can be slow due to I/O overhead, but especially when going through the daemon because of the round-trip latency of every wopAddToStore call. So we now do the addToStore() calls asynchronously from a separate thread from the evaluator. This slightly speeds up the local store, and makes going through the daemon almost as fast as a local store.
edolstra
force-pushed
the
async-path-writer
branch
from
5b14ce0 to
268d1b1
Compare
This was referenced Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adding paths to the store can be slow due to I/O overhead, but especially when going through the daemon because of the round-trip latency of every
wopAddToStorecall.So we now do the
addToStore()calls asynchronously from a separate thread from the evaluator. This slightly speeds up the local store, and makes going through the daemon almost as fast as a local store.Timings doing
nix eval github:NixOS/hydra/b812bb5017cac055fa56ffeac5440b6365830d67#nixosConfigurations.container.config.system.build.toplevel:Context