Make GitFileSystemObjectSink multi-threaded#149
Merged
edolstra merged 13 commits intodetsys-mainfrom Jul 28, 2025
Merged
Conversation
edolstra
added
the
flake-regression-test
On Linux, it makes import slower, but on macOS, we really need it.
edolstra
force-pushed
the
multithreaded-git-sink-2
branch
from
51861d6 to
c478d98
Compare
cole-h
reviewed
Jul 16, 2025
Comment on lines
1023
to
1030
| bool useMempack = | ||
| // On macOS, mempack is beneficial. | ||
| #ifdef __linux__ | ||
| false | ||
| #else | ||
| true | ||
| #endif | ||
| ; |
Member
There was a problem hiding this comment.
Nit: Should this be ifdef macos true instead? Since we know that it's beneficial on macOS, but it may not be beneficial on e.g. FreeBSD or Windows, etc (I don't know if those platforms even get here, but to me it'd be more readable this way)
cole-h
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Updated version of upstream NixOS#12087. It makes importing tarballs into the tarball cache quite a bit faster (e.g. 11.7s to 3.6s for nixpkgs master on Linux, 14.7s to 7.2s on macOS).
Benchmarked using:
Context