Conversation
…ms/allow-obliterating-id-token-privs` (`4280bc94c9545f31ccf08001cc16f20ccb91b770`)
Member
Author
colemickens
reviewed
Nov 6, 2024
Comment on lines
+227
to
+230
| "--use-gha-cache", | ||
| useGhaCache, | ||
| "--use-flakehub", | ||
| useFlakeHub, |
Member
There was a problem hiding this comment.
I'm surprised to see these as new additions?
Member
There was a problem hiding this comment.
Oh, it's literally the next section, never mind, I see how they moved.
colemickens
reviewed
Nov 6, 2024
| uses: DeterminateSystems/nix-installer-action@main | ||
| with: | ||
| flakehub: true | ||
| _internal-obliterate-actions-id-token-request-variables: ${{ matrix.id-token == 'none' }} |
Member
There was a problem hiding this comment.
what's this for? _internal-obliterate... ?
Member
Author
There was a problem hiding this comment.
I want those actions to not have the ACTIONS_ID_TOKEN_REQUEST_* environment variables, so they can't create an ID token and log in to flakehub. This simulates not having the id-token: write permission. I wanted to parameterize that permission in the matrix, but permissions can't be variable.
colemickens
approved these changes
Nov 6, 2024
Member
colemickens
left a comment
colemickens
left a comment
There was a problem hiding this comment.
awesome, very slick, definitely increases my confidence about things.
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist