Skip to content

ci workflow: don't check initial substituter list#90

Merged
colemickens merged 4 commits intomainfrom
colemickens/ci-relax-sub-check
Sep 26, 2024
Merged

ci workflow: don't check initial substituter list#90
colemickens merged 4 commits intomainfrom
colemickens/ci-relax-sub-check

Conversation

@colemickens
Copy link
Copy Markdown
Member

Description

chatted with @grahamc, we want to just drop this check.

Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

cole-h
cole-h previously approved these changes Sep 25, 2024
@colemickens
Copy link
Copy Markdown
Member Author

colemickens commented Sep 25, 2024

Closing in favor of the better, more proper fix in MNC itself: DeterminateSystems/magic-nix-cache#107

EDIT: this comment was incorrect, maybe meant for a different PR. Anyway I didn't actually close it...

@grahamc
Copy link
Copy Markdown
Member

grahamc commented Sep 25, 2024

I think we'll need this change anyway!

@colemickens colemickens added this pull request to the merge queue Sep 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2024
@colemickens colemickens added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@colemickens colemickens requested a review from cole-h September 26, 2024 18:39
@colemickens colemickens dismissed cole-h’s stale review September 26, 2024 18:39

change, want a re-review

@colemickens colemickens added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@colemickens colemickens added this pull request to the merge queue Sep 26, 2024
…lines not printed for dnixd-subscriber scenario
@colemickens colemickens removed this pull request from the merge queue due to a manual request Sep 26, 2024
@colemickens colemickens force-pushed the colemickens/ci-relax-sub-check branch from 49ff4ea to d6f16e9 Compare September 26, 2024 19:04
@colemickens colemickens added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit a76a830 Sep 26, 2024
@colemickens colemickens deleted the colemickens/ci-relax-sub-check branch September 26, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants