include --flakehub-api-server-netrc for non-flakehub/determinate runs#87
Closed
colemickens wants to merge 1 commit intomainfrom
Closed
include --flakehub-api-server-netrc for non-flakehub/determinate runs#87colemickens wants to merge 1 commit intomainfrom
colemickens wants to merge 1 commit intomainfrom
Conversation
Member
Author
|
Closing in favor of the better, more proper fix in MNC itself: DeterminateSystems/magic-nix-cache#107 |
detsys-pr-bot
pushed a commit
to detsys-pr-bot/magic-nix-cache-action
that referenced
this pull request
Apr 7, 2025
…m DeterminateSystems/dependabot/npm_and_yarn/npm-deps-2f3c1638ee` (`e31aa55518cae49b58723c152c6d0e46ee223ec1`)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 7, 2025
…ms/dependabot/npm_and_yarn/npm-deps-2f3c1638ee` (`e31aa55518cae49b58723c152c6d0e46ee223ec1`) (#121) Co-authored-by: lucperkins <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context:
I think this is the easiest change/fix here to reason about. Just include the netrc flag always. It will be ignored for determinate, and be set to the logged in netrcPath() result otherwise.
I'm fairly concerned we didn't catch this for almost a week. I feel like this points to some potential monitoring gaps.
Checklist