Merged
Conversation
cole-h
reviewed
May 20, 2024
cole-h
reviewed
May 20, 2024
grahamc
reviewed
May 22, 2024
grahamc
approved these changes
May 22, 2024
Co-authored-by: Graham Christensen <[email protected]>
cole-h
reviewed
May 22, 2024
cole-h
reviewed
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general, the
magic-nix-cache-actionhandles errors very leniently because it needs to not take down your workflow with it. The problem with this, though, is that it's hard to know if the Action itself is working properly in our own CI suite. This PR addresses that by adding a strict mode toggle intended only for this environment.