Don't mark the daemon started until after we successfully import the …#49
Merged
Don't mark the daemon started until after we successfully import the …#49
Conversation
cole-h
reviewed
May 8, 2024
Comment on lines
204
to
208
| this.daemonStarted = true; | ||
| actionsCore.saveState(STATE_STARTED, STARTED_HINT); | ||
|
|
||
| // Start the server. Once it is ready, it will notify us via the notification server. | ||
| const daemon = spawn(daemonBin, daemonCliFlags, opts); |
Member
There was a problem hiding this comment.
Why don't we just move it after we spawn the daemon? That seems like a more correct time to say it's been started.
Or maybe even right after we log "Launched Magic Nix Cache" after waiting for it to start...?
cole-h
approved these changes
May 8, 2024
Member
cole-h
left a comment
cole-h
left a comment
There was a problem hiding this comment.
LGTM after my comment is addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…closure
Description
Checklist