Instance attribute becomes Unknown when type has __getattr__, but pyright handles it correctly #1719

Activity

1. janfrederik

   added a commit that references this issue on Feb 4, 2026

   Standardize gitlab.v4.objects.Project import path across codebase

   ...

   f563092
2. DetachHead

   added

   needs investigationawaiting verification by a maintainer that the issue is validawaiting verification by a maintainer that the issue is valid

   on Feb 4, 2026
3. DetachHead commented on Feb 7, 2026

   

   DetachHead

   on Feb 7, 2026

   Owner

   More actions

   Standard pyright does not have this issue.

   this is just because pyright's defaults are less strict than basedpyright's (more info). the same error occurs in pyright if you enable these rules:

   [tool.pyright]
   reportUnknownMemberType = true
   reportUnknownVariableType = true

   Playground link - uses a simplified example since gitlab isn't available in playground.

   not sure what's going on here... i assume this isn't what you were trying to show:

   

   Reproduction

   from __future__ import annotations
   from typing import TYPE_CHECKING, Any
   
   if TYPE_CHECKING:
       from gitlab.v4.objects import Project  # Has __getattr__ via RESTObject base class
   
   class Handler:
       _project: Project  # Explicitly declared type
   
       def __init__(self, project: Project) -> None:
           self._project = project  # Assignment is type-checked
   
       def get_project(self) -> Project:
           return self._project  # Warning: Return type is unknown

   i'm not sure what was supposed to be in the minimal playground example, but in this example here the issue doesn't seem to be related to the __getattr__, but rather the RepositoryMixin class that Project extends:

   # gitlab/v4/objects/repositories.py
   if TYPE_CHECKING:
       # When running mypy we use these as the base classes
       _RestObjectBase = gitlab.base.RESTObject
   else:
       _RestObjectBase = object
   
   
   class RepositoryMixin(_RestObjectBase):
       ...

   it looks like some sort of hack to work around a mypy bug. but this isn't compatible with pyright because the base module cannot be accessed directly from gitlab that way (more info). this causes the _RestObjectBase class to be Unknown, which is whatt's causing your error.

   i would recommend opening an issue at https://github.com/python-gitlab/python-gitlab.

   here's a minimal repro:

   class Foo(asdf):...  # error: reportUndefinedVariable
   
   class Handler:
       _project: Foo
   
       def __init__(self, project: Foo) -> None:
           self._project = project
   
       def get_project(self):
           return self._project  # Warning: Return type is unknown
4. DetachHead

   added

   awaiting responsewaiting for more info from the author - will eventually close if they don't respondwaiting for more info from the author - will eventually close if they don't respond

   and removed

   needs investigationawaiting verification by a maintainer that the issue is validawaiting verification by a maintainer that the issue is valid

   on Feb 7, 2026
5. janfrederik commented on Feb 10, 2026

   

   janfrederik

   on Feb 10, 2026

   Author

   More actions

   @DetachHead Ok, clear. Thank you for your analysis!

   So I see a that just adding a simple import gitlab.base to the type checking block in gitlab/v4/objects/repositories.py does the trick:

   # gitlab/v4/objects/repositories.py
   if TYPE_CHECKING:
       # When running mypy we use these as the base classes
       import gitlab.base         # Add this line
       _RestObjectBase = gitlab.base.RESTObject
   else:
       _RestObjectBase = object
   
   
   class RepositoryMixin(_RestObjectBase):
       ...

   I'll file an issue with python-gitlab.
6. janfrederik

   closed this as completedon Feb 10, 2026
7. DetachHead

   closed this as not plannedon Feb 10, 2026