fix: harden Slack socket teardown shutdown

frankekn · frankekn · commit f1c91d50b0a1 · 2026-04-04T20:40:03.000+08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -610,6 +610,7 @@ Docs: https://docs.openclaw.ai
 - Telegram/forum topics: keep native `/new` and `/reset` routed to the active topic by preserving the topic target on forum-thread command context. (#35963)
 - Status/port diagnostics: treat single-process dual-stack loopback gateway listeners as healthy in `openclaw status --all`, suppressing false "port already in use" conflict warnings. (#53398) Thanks @DanWebb1949.
 - CLI/Docker: treat loopback private-host CLI gateway connects as local for silent pairing auto-approval, while keeping remote backend and public-host CLI connects behind pairing. (#55113) Thanks @sar618.
+- Slack/socket mode: mark the underlying socket client as shutting down before provider stop paths call Bolt teardown so stale-socket restarts stop leaking orphaned ping reconnect loops. (#56646) Thanks @hsiaoa.
 
 ## 2026.3.24
 
diff --git a/extensions/slack/src/monitor/provider.reconnect.test.ts b/extensions/slack/src/monitor/provider.reconnect.test.ts
@@ -104,4 +104,18 @@ describe("slack socket reconnect helpers", () => {
       error: err,
     });
   });
+
+  it("marks the socket client as shutting down before stop runs", async () => {
+    const app = {
+      receiver: { client: { shuttingDown: false } },
+      stop: vi.fn().mockImplementation(async () => {
+        expect(app.receiver.client.shuttingDown).toBe(true);
+      }),
+    };
+
+    await __testing.gracefulStopSlackApp(app);
+
+    expect(app.stop).toHaveBeenCalledTimes(1);
+    expect(app.receiver.client.shuttingDown).toBe(true);
+  });
 });
diff --git a/extensions/slack/src/monitor/provider.ts b/extensions/slack/src/monitor/provider.ts
@@ -228,7 +228,6 @@ function formatSlackUserResolved(entry: SlackUserResolution): string {
     extra: entry.note ? [entry.note] : [],
   });
 }
-
 export async function monitorSlackProvider(opts: MonitorSlackOpts = {}) {
   const cfg = opts.config ?? loadConfig();
   const runtime: RuntimeEnv = opts.runtime ?? createNonExitingRuntime();

Original file line number	Diff line number	Diff line change
`@@ -228,7 +228,6 @@ function formatSlackUserResolved(entry: SlackUserResolution): string {`
`228`	`228`	`extra: entry.note ? [entry.note] : [],`
`229`	`229`	`});`
`230`	`230`	`}`
`231`		`-`
`232`	`231`	`export async function monitorSlackProvider(opts: MonitorSlackOpts = {}) {`
`233`	`232`	`const cfg = opts.config ?? loadConfig();`
`234`	`233`	`const runtime: RuntimeEnv = opts.runtime ?? createNonExitingRuntime();`