Skip to content

improve detection if version is commit sha or release tag for github purl#5265

Merged
nscuro merged 1 commit intoDependencyTrack:masterfrom
snieguu:4945
Sep 3, 2025
Merged

improve detection if version is commit sha or release tag for github purl#5265
nscuro merged 1 commit intoDependencyTrack:masterfrom
snieguu:4945

Conversation

@snieguu
Copy link
Copy Markdown
Contributor

@snieguu snieguu commented Aug 29, 2025 •
edited by nscuro
Loading

Description

Improve detection if version is commit sha or release tag for github purl

Addressed Issue

Fixes #4945

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@owasp-dt-bot
Copy link
Copy Markdown

owasp-dt-bot commented Aug 29, 2025

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Aug 29, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 7023e311 ✅ 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7023e31) Report Missing Report Missing Report Missing
Head commit (4008819) 23977 19383 80.84%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#5265) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@nscuro nscuro added this to the 4.14.0 milestone Sep 3, 2025
@nscuro nscuro added defect Something isn't working backport/4.13.5 PRs to be backported to v4.13.5 labels Sep 3, 2025
nscuro
nscuro approved these changes Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nscuro nscuro merged commit 87e82c9 into DependencyTrack:master Sep 3, 2025
10 checks passed
@nscuro nscuro mentioned this pull request Sep 29, 2025
Merged
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nscuro nscuro nscuro approved these changes

Assignees

No one assigned

Labels

backport/4.13.5 PRs to be backported to v4.13.5 defect Something isn't working

Projects

None yet

Milestone

4.14.0

Development

Successfully merging this pull request may close these issues.

GithubMetaAnalyzer throws exception "No commit found for SHA: 3.1.0"

3 participants

@snieguu @owasp-dt-bot @nscuro