Skip to content

fix null when NuGet package has only pre-released versions#5264

Merged
nscuro merged 1 commit intoDependencyTrack:masterfrom
snieguu:5075
Aug 29, 2025
Merged

fix null when NuGet package has only pre-released versions#5264
nscuro merged 1 commit intoDependencyTrack:masterfrom
snieguu:5075

Conversation

@snieguu
Copy link
Copy Markdown
Contributor

@snieguu snieguu commented Aug 29, 2025 •
edited by nscuro
Loading

Description

Fix null when computing latest version for NuGet package that has only pre-released versions

Addressed Issue

Fixes #5075

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@owasp-dt-bot
Copy link
Copy Markdown

owasp-dt-bot commented Aug 29, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

@snieguu snieguu changed the title fix null when NuGet package has only pre-released version fix null when NuGet package has only pre-released versions Aug 29, 2025
@nscuro nscuro added the defect Something isn't working label Aug 29, 2025
@nscuro nscuro added this to the 4.14.0 milestone Aug 29, 2025
@nscuro
Copy link
Copy Markdown
Member

nscuro commented Aug 29, 2025

Thanks @snieguu! There seems to be a related test failure:

NugetMetaAnalyzerTest.testAnalyzer:83 expected: not

@nscuro nscuro added the backport/4.13.5 PRs to be backported to v4.13.5 label Aug 29, 2025
@snieguu
Copy link
Copy Markdown
Contributor Author

snieguu commented Aug 29, 2025 •
edited
Loading

@nscuro now, my favourite flaky test PolicyEngineTest.notificationTest:395 failing, please rerun

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Aug 29, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ -0.09% (target: -1.00%) ✅ 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c0c9a76) 24093 19498 80.93%
Head commit (573da73) 23974 (-119) 19380 (-118) 80.84% (-0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#5264) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

nscuro
nscuro approved these changes Aug 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nscuro nscuro merged commit 7023e31 into DependencyTrack:master Aug 29, 2025
11 of 13 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nscuro nscuro nscuro approved these changes

Assignees

No one assigned

Labels

backport/4.13.5 PRs to be backported to v4.13.5 defect Something isn't working

Projects

None yet

Milestone

4.14.0

Development

Successfully merging this pull request may close these issues.

Error in CacheStampedeBlocker for pre-release only NuGet packages

3 participants

@snieguu @owasp-dt-bot @nscuro