Fix Issue#5105: OSV Ubuntu advisory contains severity without type (ubuntu priority)#5106
Merged
nscuro merged 1 commit intoDependencyTrack:masterfrom Jul 8, 2025
jonbally:master
Merged
Fix Issue#5105: OSV Ubuntu advisory contains severity without type (ubuntu priority)#5106nscuro merged 1 commit intoDependencyTrack:masterfrom jonbally:master
nscuro merged 1 commit intoDependencyTrack:masterfrom
jonbally:master
Conversation
The missing type caused a NullPointerException when the OsvAdvisoryParser.parse() method tried to access the type without checking for null. My fix will check if type is null and continue the loop without further processing the item. I have also added a test for this case and fixed testGetEcosystems() in the OsvDownloadTaskTest that incorrectly checked for null instead of an empty list after attempting to fetch the ecosystem list. Signed-off-by: jonbally <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
nscuro
added
defect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The missing type in some Ubuntu OSV advisories caused a NullPointerException when the OsvAdvisoryParser.parse() method tried to access the type without checking for null. My fix will check if type is null and continue the loop without further processing the item. I have also added a test for this case and additionally fixed testGetEcosystems() in the OsvDownloadTaskTest that incorrectly checked for null instead of an empty list after attempting to fetch the ecosystem list.
Addressed Issue
Fixes #5105
Additional Details
I am still wondering why the import of these advisories has worked correctly at some point (they are present when I look for them in the frontend) and why this issue has not yet been reported here, because some of the affected advisories are very old.
Did something else change recently? Anyway it makes sense to check for null before accessing the
type.Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly