Skip to content

switch cvss handling to metaeffekt#4968

Merged
nscuro merged 1 commit intoDependencyTrack:masterfrom
stohrendorf:metaeffekt-cvss
May 19, 2025
Merged

switch cvss handling to metaeffekt#4968
nscuro merged 1 commit intoDependencyTrack:masterfrom
stohrendorf:metaeffekt-cvss

Conversation

@stohrendorf
Copy link
Copy Markdown
Contributor

Description

Uses metaeffekt CVSS implementation instead of us.springett.cvss-calculator.

Addressed Issue

Preparing step for #4707.

Additional Details

Also seems to fix a few bugs in NistMirrorTask, NistApiMirrorTask and OssIndexAnalysisTask where CVSS 3.1 vectors were silently replaced with 3.0 ones.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@owasp-dt-bot
Copy link
Copy Markdown

owasp-dt-bot commented May 17, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Signed-off-by: Steffen Ohrendorf <[email protected]>
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented May 17, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.09% (target: -1.00%) 84.55% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3c3d486) 23968 19311 80.57%
Head commit (2c2347f) 24039 (+71) 19389 (+78) 80.66% (+0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4968) 123 104 84.55%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@nscuro nscuro added the enhancement New feature or request label May 19, 2025
@nscuro nscuro added this to the 4.14.0 milestone May 19, 2025
Copy link
Copy Markdown
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nscuro nscuro merged commit e05faf4 into DependencyTrack:master May 19, 2025
11 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2025
@stohrendorf stohrendorf deleted the metaeffekt-cvss branch September 9, 2025 19:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants