Skip to content

Test performance improvements#4901

Merged
nscuro merged 8 commits intoDependencyTrack:masterfrom
stohrendorf:junit-fixes
Sep 3, 2025
Merged

Test performance improvements#4901
nscuro merged 8 commits intoDependencyTrack:masterfrom
stohrendorf:junit-fixes

Conversation

@stohrendorf
Copy link
Copy Markdown
Contributor

@stohrendorf stohrendorf commented Apr 29, 2025 •
edited
Loading

Description

Follow-up to #4832.

  • Enables fork-reuse to speed up tests.
  • Makes tests dependent on Jersey locale-independent again.
  • Improves some non-deterministic tests.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@owasp-dt-bot
Copy link
Copy Markdown

owasp-dt-bot commented Apr 29, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

@stohrendorf stohrendorf marked this pull request as draft April 30, 2025 04:11
@stohrendorf stohrendorf changed the title Junit fixes Test performance improvements May 1, 2025
@stohrendorf stohrendorf force-pushed the junit-fixes branch 2 times, most recently from 9164d8e to 178a00c Compare August 18, 2025 13:06
@stohrendorf
ensure DB is closed after tests
b1b103b 
Signed-off-by: Steffen Ohrendorf <[email protected]>
@stohrendorf
reuse forks for tests to speed them up
2088acf 
Signed-off-by: Steffen Ohrendorf <[email protected]>
@stohrendorf
ensure jersey tests respect the DefaultLocale annotation
b123dbe 
Signed-off-by: Steffen Ohrendorf <[email protected]>
@stohrendorf
fix some non-deterministic tests
1031da8 
Signed-off-by: Steffen Ohrendorf <[email protected]>
@stohrendorf
make SearchManager a utility class
b00f5ba 
Signed-off-by: Steffen Ohrendorf <[email protected]>
@stohrendorf
ensure DefaultLocale annotation is applied during tests
bc07f72 
Signed-off-by: Steffen Ohrendorf <[email protected]>
@stohrendorf
fix autocomplete typo in IndexConstants
1c79d97 
Signed-off-by: Steffen Ohrendorf <[email protected]>
@stohrendorf
add debug toString to Vulnerability
20ae0be 
Signed-off-by: Steffen Ohrendorf <[email protected]>
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Sep 1, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 7023e311 ✅ 88.89% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7023e31) Report Missing Report Missing Report Missing
Head commit (20ae0be) 23966 19369 80.82%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4901) 9 8 88.89%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@stohrendorf stohrendorf marked this pull request as ready for review September 1, 2025 18:36
@nscuro nscuro added the enhancement New feature or request label Sep 3, 2025
@nscuro nscuro added this to the 4.14.0 milestone Sep 3, 2025
nscuro
nscuro approved these changes Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @stohrendorf, 22min -> 8min is a huge improvement! Thanks so much!

@nscuro nscuro merged commit 9d9a322 into DependencyTrack:master Sep 3, 2025
11 checks passed
@stohrendorf
Copy link
Copy Markdown
Contributor Author

stohrendorf commented Sep 3, 2025

Cheers :)

@stohrendorf stohrendorf deleted the junit-fixes branch September 9, 2025 19:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nscuro nscuro nscuro approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

4.14.0

Development

Successfully merging this pull request may close these issues.

3 participants

@stohrendorf @owasp-dt-bot @nscuro