Skip to content

Fix component properties not being cloned#4745

Merged
nscuro merged 1 commit intoDependencyTrack:masterfrom
nscuro:component-property-cloning
Mar 11, 2025
Merged

Fix component properties not being cloned#4745
nscuro merged 1 commit intoDependencyTrack:masterfrom
nscuro:component-property-cloning

Conversation

@nscuro
Copy link
Copy Markdown
Member

@nscuro nscuro commented Mar 11, 2025

Description

Fixes component properties not being cloned.

When cloning a project with includeComponents option, component properties were previously not considered. This lead to properties being "lost" in the cloned project.

Users relying on scanners such as Trivy, which make use of component properties to assist in vulnerability detection, could have observed fewer findings being detected in cloned projects.

Addressed Issue

Backports DependencyTrack/hyades-apiserver#1089

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added defect Something isn't working backport/4.12.7 labels Mar 11, 2025
@nscuro nscuro added this to the 4.13 milestone Mar 11, 2025
@codacy-production
Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (965e09c) 23281 18696 80.31%
Head commit (23afb5c) 23295 (+14) 18710 (+14) 80.32% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4745) 14 14 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 83d8388 into DependencyTrack:master Mar 11, 2025
11 checks passed
@nscuro nscuro deleted the component-property-cloning branch March 11, 2025 12:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

defect Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant