Skip to content

Prevent application startup when migrations fail#4681

Merged
nscuro merged 1 commit intoDependencyTrack:masterfrom
nscuro:migration-fail-startup
Feb 22, 2025
Merged

Prevent application startup when migrations fail#4681
nscuro merged 1 commit intoDependencyTrack:masterfrom
nscuro:migration-fail-startup

Conversation

@nscuro
Copy link
Copy Markdown
Member

@nscuro nscuro commented Feb 22, 2025

Description

Prevents application startup when migrations fail.

Previously, failures during migrations were only logged, but application startup was not aborted. This could possibly lead to users never knowing whether migrations failed.

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended~
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Previously, failures during migrations were only logged, but application startup was not aborted. This could possibly lead to users never knowing whether migrations failed.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the enhancement New feature or request label Feb 22, 2025
@nscuro nscuro added this to the 4.13 milestone Feb 22, 2025
@codacy-production
Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (297f3b2) 23115 18548 80.24%
Head commit (1d963db) 23115 (+0) 18548 (+0) 80.24% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4681) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 583f112 into DependencyTrack:master Feb 22, 2025
11 checks passed
@nscuro nscuro deleted the migration-fail-startup branch February 22, 2025 21:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant