Skip to content

Backport: Analyze all components of a project at once instead of in batches#4673

Merged
nscuro merged 1 commit intoDependencyTrack:4.12.xfrom
nscuro:backport-pr-4670
Feb 19, 2025
Merged

Backport: Analyze all components of a project at once instead of in batches#4673
nscuro merged 1 commit intoDependencyTrack:4.12.xfrom
nscuro:backport-pr-4670

Conversation

@nscuro
Copy link
Copy Markdown
Member

@nscuro nscuro commented Feb 19, 2025

Description

Analyzes all components of a project at once instead of in batches.

Unfortunately this is necessary to support Trivy properly, because it checks for the existence of OPERATING_SYSTEM components in a project. If we were to analyze components in batches, this logic might not work for large projects.

Addressed Issue

Backports #4670

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Unfortunately this is necessary to support Trivy properly, because it checks for the existence of `OPERATING_SYSTEM` components in a project. If we were to analyze components in batches, this logic might not work for large projects.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added defect Something isn't working integration/trivy Related to the Trivy integration labels Feb 19, 2025
@nscuro nscuro added this to the 4.12.6 milestone Feb 19, 2025
@codacy-production
Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 66.67% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e41c28f) 22692 18154 80.00%
Head commit (6adea33) 22677 (-15) 18141 (-13) 80.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4673) 9 6 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit cce0e43 into DependencyTrack:4.12.x Feb 19, 2025
7 of 8 checks passed
@nscuro nscuro deleted the backport-pr-4670 branch February 19, 2025 15:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

defect Something isn't working integration/trivy Related to the Trivy integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant