Skip to content

Handle GitHub GraphQL API rate limiting#4578

Merged
nscuro merged 1 commit intoDependencyTrack:masterfrom
nscuro:issue-4291-
Jan 25, 2025
Merged

Handle GitHub GraphQL API rate limiting#4578
nscuro merged 1 commit intoDependencyTrack:masterfrom
nscuro:issue-4291-

Conversation

@nscuro
Copy link
Copy Markdown
Member

@nscuro nscuro commented Jan 22, 2025

Description

  • Handles GitHub GraphQL API rate limiting.
  • Migrates the GitHub Advisories mirroring logic to the Open-Vulnerability-Project client.
  • Utilizes incremental mirroring similar to how it's done for the NVD REST API.
  • Adapts a more efficient synchronization logic, as already utilized by NVD REST API mirroring.

Addressed Issue

Fixes #4291
Fixes #2497

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added defect Something isn't working backport/4.12.3 labels Jan 22, 2025
@nscuro nscuro added this to the 4.13 milestone Jan 22, 2025
@nscuro nscuro force-pushed the issue-4291- branch 3 times, most recently from 170b441 to 6933ba2 Compare January 24, 2025 13:45
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Jan 24, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.26% (target: -1.00%) 57.18% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (74462be) 23032 18301 79.46%
Head commit (6fec5bf) 22997 (-35) 18333 (+32) 79.72% (+0.26%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4578) 376 215 57.18%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

* Migrates the GitHub Advisories mirroring logic to the Open-Vulnerability-Project client.
* Utilizes incremental mirroring similar to how it's done for the NVD REST API.
* Adapts a more efficient synchronization logic, as already utilized by NVD REST API mirroring.

Fixes DependencyTrack#4291
Fixes DependencyTrack#2497

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro marked this pull request as ready for review January 25, 2025 18:54
@nscuro nscuro merged commit 80bb597 into DependencyTrack:master Jan 25, 2025
@nscuro nscuro deleted the issue-4291- branch January 25, 2025 18:54
nscuro added a commit to DependencyTrack/hyades that referenced this pull request Jan 27, 2025
Ports DependencyTrack/dependency-track#4578 from Dependency-Track v4.12.3

Signed-off-by: nscuro <[email protected]>
nscuro added a commit to DependencyTrack/hyades that referenced this pull request Jan 28, 2025
Ports DependencyTrack/dependency-track#4578 from Dependency-Track v4.12.3

Signed-off-by: nscuro <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

defect Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Advisory Mirroring recursion does not properly handle secondary rate limits Incomplete GitHub Advisory Vulnerability Data

1 participant