Fix CPE matching logic for NVD Rest#4339
Merged
nscuro merged 1 commit intoDependencyTrack:masterfrom Oct 29, 2024
Merged
Conversation
Signed-off-by: Thomas Calderon <[email protected]>
calderonth
force-pushed
the
fix-cpe-match-signed
branch
from
3f44b42 to
7f915f7
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This aligns the CPE matching logic for NVD between the feed and the REST API. I believe that when the logic was ported the nodeOperator was not properly copied over.
I added an additional unit-test to demonstrate where it previously failed and changing the operator does not break the previous unit-test either.
Addressed Issue
Fixes #4255
Additional Details
Checklist