Skip to content

Commit 0cf231e

Browse files
committed
Fix erroneous URL-encoding of the Maven groupId
Fixes #4601 Signed-off-by: nscuro <[email protected]>
1 parent 9bef0c9 commit 0cf231e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/main/java/org/dependencytrack/tasks/repositories/MavenMetaAnalyzer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public RepositoryType supportedRepositoryType() {
7676
public MetaModel analyze(final Component component) {
7777
final MetaModel meta = new MetaModel(component);
7878
if (component.getPurl() != null) {
79-
final String mavenGavUrl = urlEncode(component.getPurl().getNamespace().replaceAll("\\.", "/")) + "/" + urlEncode(component.getPurl().getName());
79+
final String mavenGavUrl = urlEncode(component.getPurl().getNamespace()).replaceAll("\\.", "/") + "/" + urlEncode(component.getPurl().getName());
8080
final String url = String.format(baseUrl + REPO_METADATA_URL, mavenGavUrl);
8181
try (final CloseableHttpResponse response = processHttpRequest(url)) {
8282
if (response.getStatusLine().getStatusCode() == HttpStatus.SC_OK) {

src/test/java/org/dependencytrack/tasks/repositories/MavenMetaAnalyzerTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,4 +54,5 @@ public void testAnalyzerForScalaComponent() throws Exception {
5454
Assert.assertNotNull(metaModel.getLatestVersion());
5555
Assert.assertNotNull(metaModel.getPublishedTimestamp());
5656
}
57+
5758
}

0 commit comments

Comments
 (0)