Fixed allocating a large amount of memory with pixel coordinates#45
Merged
DirkEilander merged 2 commits intoDeltares:mainfrom Dec 19, 2024
Merged
Conversation
…the whole image at once.
DirkEilander
approved these changes
Dec 19, 2024
Contributor
DirkEilander
left a comment
DirkEilander
left a comment
There was a problem hiding this comment.
Many thanks for this contribution @vzagorovskiy. I think it looks excellent and is ready to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed allocating a large amount of memory with pixel coordinates for the whole image at once.
Issue addressed
Fixes #44
Explanation
FlwdirRaster.stream crashed on a huge rasters on a machine with 16 GB or less
Checklist
mainAdditional Notes (optional)
Tests showed successful work on large images, the speed of work on small images has not changed. The changes do not break the current program logic and do not require additional changes in the existing code.