Skip to content

Conversation

@Fr0sT-Brutal
Copy link
Contributor

WARNING this PR depends on changes made by feat_read-searchpath-from-dproj PR.

@Laurensvanrun
Copy link
Contributor

Thanks for your contribution. Can you also add tests for reading this information from the DPROJ?

@Fr0sT-Brutal
Copy link
Contributor Author

Done! I can rebase the commit once you merge feat_read-searchpath-from-dproj for simpler history

@Laurensvanrun
Copy link
Contributor

That would be nice, feat_read-searchpath-from-dproj is merged.

@Fr0sT-Brutal Fr0sT-Brutal deleted the feat_codepage branch August 10, 2021 14:35
@Fr0sT-Brutal Fr0sT-Brutal mentioned this pull request Aug 10, 2021
@Fr0sT-Brutal
Copy link
Contributor Author

Closed this accidentally by removing branh, so rereated as #11

@Laurensvanrun
Copy link
Contributor

I'm I correct that it reads the codepage from the DPROJ by default and that your commandline parameter overrules it? If so, can you please add this as comment in the readme?

@Fr0sT-Brutal
Copy link
Contributor Author

Well, I've short of time currently and can't check but it seems to me that this depends on the order of arguments because DPROJ is read right when the option is encountered. So if -cp appears after, it will overwrite the value read from DPROJ

@Fr0sT-Brutal
Copy link
Contributor Author

@Laurensvanrun added the note

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants