Skip to content

chore: typo#74140

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
HomyeeKing:patch-4
Jan 10, 2026
Merged

chore: typo#74140
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
HomyeeKing:patch-4

Conversation

@HomyeeKing
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 26, 2025

@HomyeeKing Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74140,
  "author": "HomyeeKing",
  "headCommitOid": "9318ec53b7fb562bebdca61165d9da4c9b0fd2b7",
  "mergeBaseOid": "c303b673ad62dd854c4d4df110c4133450420e53",
  "lastPushDate": "2025-11-26T11:41:36.000Z",
  "lastActivityDate": "2026-01-10T09:00:05.000Z",
  "mergeOfferDate": "2026-01-09T18:48:01.000Z",
  "mergeRequestDate": "2026-01-10T09:00:05.000Z",
  "mergeRequestUser": "HomyeeKing",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "vscode",
      "kind": "edit",
      "files": [
        {
          "path": "types/vscode/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "microsoft"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2026-01-09T18:47:19.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "HolgerJeromin",
      "date": "2025-12-09T14:39:06.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 3580927224,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Nov 26, 2025
@HomyeeKing
Copy link
Contributor Author

image

Btw, will the website be auto updated?

@typescript-bot
Copy link
Contributor

Hey @HomyeeKing,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @microsoft — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Nov 26, 2025
@typescript-bot
Copy link
Contributor

Re-ping @microsoft:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Dec 7, 2025
@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews (Blessed) in Pull Request Status Board Dec 8, 2025
@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Dec 9, 2025
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @HomyeeKing.

(Ping @microsoft.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews (Blessed) to Needs Maintainer Action in Pull Request Status Board Dec 14, 2025
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Jan 9, 2026
@typescript-bot
Copy link
Contributor

@HomyeeKing: Everything looks good here. I am ready to merge this PR (at 9318ec5) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in Pull Request Status Board Jan 9, 2026
@HomyeeKing
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Jan 10, 2026
@typescript-bot typescript-bot merged commit 591fde5 into DefinitelyTyped:master Jan 10, 2026
4 checks passed
joanlopez pushed a commit to grafana/k6-DefinitelyTyped that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved Other Approved This PR was reviewed and signed-off by a community member. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants