Skip to content

Fix VS Code types #74099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 1 commit into from
Nov 17, 2025
Merged

Fix VS Code types #74099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions types/vscode/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@
"@definitelytyped/strict-export-declare-modifiers": "off",
"@definitelytyped/no-single-declare-module": "off",
"@typescript-eslint/no-unsafe-function-type": "off",
"@typescript-eslint/no-wrapper-object-types": "off",
"@typescript-eslint/no-wrapper-object-types": "off",
"@typescript-eslint/no-empty-interface": "off",
"@typescript-eslint/no-invalid-void-type": "off",
"@typescript-eslint/array-type": "off"
"@typescript-eslint/array-type": "off",
"jsdoc/check-tag-names": "off"
}
}
4 changes: 3 additions & 1 deletion types/vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
"private": true,
"name": "@types/vscode",
"version": "1.106.9999",
"nonNpm": "conflict",
"nonNpmDescription": "TypeScript definitions for the Visual Studio Code Extension API",
Comment on lines +5 to +6
Copy link
Member Author

@jakebailey jakebailey Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjbvz Is this file also generated by you? If so, I'd like to make sure these two lines are generated too.

Copy link
Collaborator

@mjbvz mjbvz Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one isn't. Just the vscode.d.ts

Copy link
Member Author

@jakebailey jakebailey Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? The version in this file needs to be updated so I believe this must be modified somehow.

Copy link
Collaborator

@mjbvz mjbvz Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The person running the release manually bumps it. We didn’t automate this afaik

Copy link
Member Author

@jakebailey jakebailey Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, huh. We should fix that. Anyway, thanks.

Copy link
Member Author

@jakebailey jakebailey Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self https://github.com/microsoft/vscode/tree/main/build/azure-pipelines/publish-types

"projects": [
"https://github.com/microsoft/vscode"
],
Expand All @@ -14,4 +16,4 @@
"githubUsername": "microsoft"
}
]
}
}