Conversation
|
@jakebailey Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74099,
"author": "jakebailey",
"headCommitOid": "c96eadc38654fc07af6f37e0b8106c81e3e970d3",
"mergeBaseOid": "2d04c5c11572f98270b7561fb59707a29da8e2b3",
"lastPushDate": "2025-11-17T17:06:05.000Z",
"lastActivityDate": "2025-11-17T17:32:59.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "vscode",
"kind": "edit",
"files": [
{
"path": "types/vscode/.eslintrc.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-eslintrcjson) and not moving towards it (check: `rules`)"
},
{
"path": "types/vscode/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"microsoft"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "mjbvz",
"date": "2025-11-17T17:23:33.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 3542978633,
"ciResult": "pass"
} |
typescript-bot
added
Popular package
|
🔔 @microsoft — please review this PR in the next few days. Be sure to explicitly select |
| "nonNpm": "conflict", | ||
| "nonNpmDescription": "TypeScript definitions for the Visual Studio Code Extension API", |
There was a problem hiding this comment.
@mjbvz Is this file also generated by you? If so, I'd like to make sure these two lines are generated too.
There was a problem hiding this comment.
This one isn't. Just the vscode.d.ts
There was a problem hiding this comment.
Are you sure? The version in this file needs to be updated so I believe this must be modified somehow.
There was a problem hiding this comment.
The person running the release manually bumps it. We didn’t automate this afaik
There was a problem hiding this comment.
Oh, huh. We should fix that. Anyway, thanks.
There was a problem hiding this comment.
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Review
in Pull Request Status Board
typescript-bot
added
the
Other Approved
3 participants
Fixes CI, then also correctly marks the package as conflicting so we can remove it from https://github.com/microsoft/DefinitelyTyped-tools/blob/main/packages/dtslint