Skip to content

Conversation

@WikiRik
Copy link
Contributor

@WikiRik WikiRik commented Apr 12, 2025

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run pnpm test <package to test>.
  • Provide a URL to documentation or source code which provides context for the suggested changes: changes between 13.12.0 and 13.15.0
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

This PR brings the type definitions up to date with release 13.15.0.

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 12, 2025

@WikiRik Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 72475,
  "author": "WikiRik",
  "headCommitOid": "44654ab596da52857405ce4f7414846073e4645c",
  "mergeBaseOid": "f70762ee191fdb67e4fb3918ead8b548c25f2ced",
  "lastPushDate": "2025-04-12T22:22:36.000Z",
  "lastActivityDate": "2025-04-12T22:22:36.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "validator",
      "kind": "edit",
      "files": [
        {
          "path": "types/validator/es/lib/isISO15924.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/es/lib/isISO31661Numeric.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/es/lib/isULID.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/lib/isISO15924.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/lib/isISO31661Numeric.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/lib/isISO4217.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/lib/isULID.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/lib/isURL.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/validator/validator-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "tgfjt",
        "chrootsu",
        "IOAyman",
        "louy",
        "deptno",
        "builtinnya",
        "qqilihq",
        "keatz55",
        "MunifTanjim",
        "vlapo",
        "peterblazejewicz",
        "Mattewn99",
        "dcfreire",
        "WikiRik"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2799060484,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Apr 12, 2025
@typescript-bot
Copy link
Contributor

🔔 @tgfjt @chrootsu @IOAyman @louy @deptno @builtinnya @qqilihq @keatz55 @MunifTanjim @vlapo @peterblazejewicz @Mattewn99 @dcfreire — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Apr 12, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Apr 12, 2025
@WikiRik WikiRik changed the title feat(validator): update types for release 13.15.0 [@types/validator] update types for release 13.15.0 Apr 12, 2025
@weswigham weswigham merged commit 7c2c7d9 into DefinitelyTyped:master Apr 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Critical package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants