feat(babel__generator): Add named export which introduced in @babel/[email protected] #72376
Conversation
|
@vovkasm Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 72376,
"author": "vovkasm",
"headCommitOid": "786cba3f7c8397c68c37f48e85e2c3f48046405d",
"mergeBaseOid": "971210c2f5f8311346d757e195daab81195bfd52",
"lastPushDate": "2025-04-03T14:36:38.000Z",
"lastActivityDate": "2025-04-03T15:59:30.000Z",
"mergeOfferDate": "2025-04-03T15:56:59.000Z",
"mergeRequestDate": "2025-04-03T15:59:30.000Z",
"mergeRequestUser": "vovkasm",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "babel__generator",
"kind": "edit",
"files": [
{
"path": "types/babel__generator/babel__generator-tests.ts",
"kind": "test"
},
{
"path": "types/babel__generator/index.d.ts",
"kind": "definition"
},
{
"path": "types/babel__generator/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"yortus",
"mgroenhoff",
"khell",
"Lyanbin"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2025-04-03T15:56:19.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2776010625,
"ciResult": "pass"
} |
|
🔔 @yortus @mgroenhoff @khell @Lyanbin — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Review
in Pull Request Status Board
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Looks correct, though I don't really get why this package is still on DT when the actual package is written in TS now.
typescript-bot
added
Maintainer Approved
Self Merge
typescript-bot
moved this from Needs Maintainer Review
to Waiting for Author to Merge
in Pull Request Status Board
|
Ready to merge |
typescript-bot
moved this from Waiting for Author to Merge
to Recently Merged
in Pull Request Status Board
|
@jakebailey I hope that babel 8 will ship with typings, but currently babel 7 do it only for selected packages |
|
I'm not sure why the version is an issue per se; what I'm seeing here looks just like the real package... |
4 participants
See babel/babel#17100
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.