[@types/diff] patched() callback can return false#72107
[@types/diff] patched() callback can return false#72107typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
patched() callback can return false#72107Conversation
|
@k-yle Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 72107,
"author": "k-yle",
"headCommitOid": "acfe9b2c5573fc9131408e5b6ac21f81764e33ae",
"mergeBaseOid": "88783ea455ba2d349c1ab904c3e0b2145ea9f064",
"lastPushDate": "2025-03-04T10:38:22.000Z",
"lastActivityDate": "2025-03-24T07:40:04.000Z",
"mergeOfferDate": "2025-03-24T05:04:20.000Z",
"mergeRequestDate": "2025-03-24T07:40:04.000Z",
"mergeRequestUser": "k-yle",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "diff",
"kind": "edit",
"files": [
{
"path": "types/diff/diff-tests.ts",
"kind": "test"
},
{
"path": "types/diff/index.d.ts",
"kind": "definition"
}
],
"owners": [
"vvakame",
"szdc",
"BendingBender",
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "iisaduan",
"date": "2025-03-24T05:03:40.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2697029433,
"ciResult": "pass"
} |
|
🔔 @vvakame @szdc @BendingBender @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Review
in Pull Request Status Board
|
Re-ping @vvakame, @szdc, @BendingBender, @peterblazejewicz: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
typescript-bot
added
the
Unreviewed
typescript-bot
moved this from Needs Maintainer Review
to Needs Maintainer Action
in Pull Request Status Board
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @k-yle. (Ping @vvakame, @szdc, @BendingBender, @peterblazejewicz.) |
typescript-bot
added
Maintainer Approved
Self Merge
typescript-bot
moved this from Needs Maintainer Action
to Waiting for Author to Merge
in Pull Request Status Board
|
@k-yle: Everything looks good here. I am ready to merge this PR (at acfe9b2) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@vvakame, @szdc, @BendingBender, @peterblazejewicz: you can do this too.) |
|
Ready to merge |
typescript-bot
moved this from Waiting for Author to Merge
to Recently Merged
in Pull Request Status Board
3 participants
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in thepackage.json.